Closes elastic#5860. Adding spyPerPage param to .spy.params instead o…

…f on the editableVis.params. Fixes elastic#5942
LeeDr · Jan 27, 2016 · 9086f50 · 9086f50
1 parent e72cbc2
commit 9086f50
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/src/plugins/spyModes/public/tableSpyMode.html b/src/plugins/spyModes/public/tableSpyMode.html
@@ -1,5 +1,5 @@
 <kbn-agg-table
   table="table"
   export-title="vis.title"
-  per-page="editableVis.params.spyPerPage">
+  per-page="spy.params.spyPerPage">
 </kbn-agg-table>
diff --git a/src/plugins/spyModes/public/tableSpyMode.js b/src/plugins/spyModes/public/tableSpyMode.js
@@ -21,8 +21,8 @@ define(function (require) {
           if (!$scope.vis || !$scope.esResp) {
             $scope.table = null;
           } else {
-            if (!$scope.editableVis.params.spyPerPage) {
-              $scope.editableVis.params.spyPerPage = PER_PAGE_DEFAULT;
+            if (!$scope.spy.params.spyPerPage) {
+              $scope.spy.params.spyPerPage = PER_PAGE_DEFAULT;
             }
 
             $scope.table = tabifyAggResponse($scope.vis, $scope.esResp, {

diff --git a/src/ui/public/visualize/spy.js b/src/ui/public/visualize/spy.js
@@ -16,6 +16,7 @@ define(function (require) {
           var $container = $el.find('.visualize-spy-container');
           var fullPageSpy = _.get($scope.spy, 'mode.fill', false);
           $scope.modes = spyModes;
+          $scope.spy.params = $scope.spy.params || {};
 
           function getSpyObject(name) {
             name = _.isUndefined(name) ? $scope.spy.mode.name : name;