Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to use static address #926

Merged
merged 3 commits into from
Dec 7, 2022
Merged

Add option to use static address #926

merged 3 commits into from
Dec 7, 2022

Conversation

BertrandD
Copy link
Contributor

Static receive & change address for regulated accounts

@BertrandD
Add option to use static address
ab787d3 
Static receive & change address for regulated accounts
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

clang-tidy review says "All clean, LGTM! 👍"

twilgenbus-ledger
twilgenbus-ledger approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@twilgenbus-ledger twilgenbus-ledger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Note-for-another-PR: I wonder if CommonBitcoinLikeKeychains::getFreshAddress(BitcoinLikeKeychain::KeyPurpose purpose) should be calling
CommonBitcoinLikeKeychains::getFreshAddresses(BitcoinLikeKeychain::KeyPurpose purpose, size_t n)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

clang-tidy review says "All clean, LGTM! 👍"

jcoatelen-ledger
jcoatelen-ledger approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@jcoatelen-ledger jcoatelen-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@BertrandD BertrandD merged commit 73ee9e2 into main Dec 7, 2022
@BertrandD BertrandD deleted the feat/static_address branch December 7, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcoatelen-ledger jcoatelen-ledger jcoatelen-ledger approved these changes

@twilgenbus-ledger twilgenbus-ledger twilgenbus-ledger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BertrandD @twilgenbus-ledger @jcoatelen-ledger