This repository has been archived by the owner on Jun 27, 2022. It is now read-only.
LIVE-545 Add Invalid channel to the list of disconnected errors #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #857 +/- ##
=======================================
Coverage 43.56% 43.56%
=======================================
Files 81 81
Lines 4823 4823
Branches 791 770 -21
=======================================
Hits 2101 2101
- Misses 2705 2708 +3
+ Partials 17 14 -3
Continue to review full report at Codecov.
|
gre
approved these changes
May 12, 2022
|
Hi @grsoares21 do you want to migrate this work to the monorepo, or should we close it? |
|
@haammar-ledger I'm closing this. I've already migrated it to the mono repo in the same PR as the firmware update. |
grsoares21
deleted the
feat/LIVE-545-add-invalid-channel-to-disconnected-errors
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common error that might happen when a device is abruptly disconnected from USB during an exchange is the "Invalid channel" error.
Defined at android/src/main/java/com/ledgerwallet/hid/LedgerHelper.java at lines 82, 85, 54 and 57.
This PR adds this error to a list of errors that get caught and mapped to a DisconnectedDevice type of error. This provides a cleaner wording for the user explaining that the device was disconnected and the user should retry the operation. Without it, the error that is displayed to the user states only "Invalid channel" which doesn't mean much and isn't even translated.
PS.: For now, a manual mapping was added in LLM in LedgerHQ/ledger-live-mobile#2432 . After this is merged and all upgrades are done to LLC and then LLM, that manual mapping can be removed.