-
Notifications
You must be signed in to change notification settings - Fork 375
LL-8941 Conditionally auto disconnect the node-hid-singleton #797
Conversation
Codecov Report
@@ Coverage Diff @@
## master #797 +/- ##
==========================================
+ Coverage 45.09% 45.59% +0.49%
==========================================
Files 83 82 -1
Lines 5060 5005 -55
Branches 897 891 -6
==========================================
Hits 2282 2282
+ Misses 2576 2527 -49
+ Partials 202 196 -6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idea lgtm, some feedback
I would like a tagged version of the |
|
I think this is good to merge again @gre ? |
Here's the second attempt at getting a automatic release of the node-hid-singleton. After the talk we had the other day @gre I think that by exposing this method
setAllowAutoDisconnect
at the transport level and allowing it to override the auto-disconnect (basically re-scheduling it again) will allow us to calltransport.setAllowAutoDisconnect(false)
at the begining of thewithDevice
implementation onhw/deviceAccess
from live-common and unsetting the flag on theonClose
for the transport, we essentially bypass the problem we have of long running tasks inside awithDevice
instance.What do you think?