Skip to content
This repository has been archived by the owner on Jun 27, 2022. It is now read-only.

[VG-2685] Get blockchain name from folder name #775

Merged
merged 1 commit into from
Jan 31, 2022
Merged

[VG-2685] Get blockchain name from folder name #775

merged 1 commit into from
Jan 31, 2022

Conversation

mgrattepanche-ledger
Copy link
Contributor

@mgrattepanche-ledger mgrattepanche-ledger commented Jan 25, 2022

What is this about?

  • The 'blockchain_name' from ATP were not very well aligned with the one from SCIDescription. This PR is about trying to fix it.
  • This should ease HSM's elfs scripts job when trying to compare ATP with SCI Description

Linked with https://github.com/LedgerHQ/crypto-assets/pull/312

🫀

@mgrattepanche-ledger mgrattepanche-ledger requested a review from a team as a code owner January 25, 2022 15:43
@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #775 (000c9af) into master (39ff487) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #775   +/-   ##
=======================================
  Coverage   43.51%   43.51%           
=======================================
  Files          81       81           
  Lines        4883     4883           
  Branches      859      859           
=======================================
  Hits         2125     2125           
  Misses       2744     2744           
  Partials       14       14           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39ff487...000c9af. Read the comment docs.

@gre gre merged commit 632b570 into LedgerHQ:master Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants