Module not found '@ledgerhq/devices/hid-framing' / https://registry.yarnpkg.com/@ledgerhq%2fdevices/hid-framing returned a 405 #763

dima-brook · 2022-07-28T11:13:25Z

Details

Impacted Library: [e.g. @ledgerhq/devices]
Version: [e.g. 7.0.0]

Describe the bug

After a clean installation of the latest version 7.0.0 the following error occurs:

Trace:
Error: https://registry.yarnpkg.com/@ledgerhq%2fdevices/hid-framing: Request "https://registry.yarnpkg.com/@ledgerhq%2fdevices/hid-framing" returned a 405
at Request.params.callback [as _callback] (/Users/dimabrook/.yarn/lib/cli.js:67038:18)
at Request.self.callback (/Users/dimabrook/.yarn/lib/cli.js:140883:22)
at Request.emit (node:events:390:28)
at Request. (/Users/dimabrook/.yarn/lib/cli.js:141855:10)
at Request.emit (node:events:390:28)
at IncomingMessage. (/Users/dimabrook/.yarn/lib/cli.js:141777:12)
at Object.onceWrapper (node:events:509:28)
at IncomingMessage.emit (node:events:402:35)
at endReadableNT (node:internal/streams/readable:1343:12)
at processTicksAndRejections (node:internal/process/task_queues:83:21)

Expected behavior

Should compile and build.

Additional context

Trying to run:

$ yarn add @ledgerhq/devices/hid-framing

Returns this error:

error An unexpected error occurred: "https://registry.yarnpkg.com/@ledgerhq%2fdevices/hid-framing: Request "https://registry.yarnpkg.com/@ledgerhq%2fdevices/hid-framing\" returned a 405".

The text was updated successfully, but these errors were encountered:

gre · 2022-07-28T13:07:41Z

@dima-brook
yarn add @ledgerhq/devices should be the way to install that library, not yarn add @ledgerhq/devices/hid-framing

dima-brook · 2022-07-28T14:43:42Z

We've already found the issue. It is here:

ledger-live/libs/ledgerjs/packages/hw-transport-webhid/src/TransportWebHID.ts

Line 7 in cf80564

import hidFraming from "@ledgerhq/devices/hid-framing";

Should be:
import hidFraming from "@ledgerhq/devices/lib/hid-framing";

gre · 2022-07-28T15:13:44Z

@elbywan could you shine a light on this when you are back? 🙏
I think the import works inside our stack (changed by 235de21) but causing issue outside.

elbywan · 2022-07-29T07:30:01Z

Hey @dima-brook @gre 👋,

We've already found the issue.

I don't think this is a problem, @ledgerhq/devices uses package exports which should map @ledgerhq/devices/hid-framing to @ledgerhq/devices/lib/hid-framing or @ledgerhq/devices/lib-es/hid-framing depending on the bundler configuration.

I tried to reproduce by creating a new app using create-react-app (since you are using react-app-rewired) and I managed to yarn build without issues.

I tried with adding either:

yarn add @ledgerhq/hw-transport-webhid

import TransportWebHID from "@ledgerhq/hw-transport-webhid";

or:

yarn add @ledgerhq/devices

import hidFraming from "@ledgerhq/devices/hid-framing";

My guess is that your stack relies on webpack 4 (or another random bundler) which does not support subpath exports. Upgrading to webpack 5 should make it work.

In any case I don't see any issues with the library itself.

oleg-savenok · 2022-08-02T10:04:14Z

You can use NormalModuleReplacementPlugin if you stuck with webpack 4.

plugins: [
	new webpack.NormalModuleReplacementPlugin(
		/@ledgerhq\/devices\/hid-framing/,
		'@ledgerhq/devices/lib/hid-framing'
	)
],

jordaaash · 2022-08-04T23:49:31Z

FWIW @ledgerhq/hw-transport and @ledgerhq/hw-transport-webhid work when pinned to the previous exact version 6.27.1 (published 2022-04-13), and this error is encountered with the latest release (6.27.2, published ~ a week ago, 2022-07-28).

alihalabyah · 2022-08-06T16:01:54Z

@jordansexton Tried that but it did not work

jordaaash · 2022-08-06T16:37:29Z

@alihalabyah pinning versions is tricky because the dependencies declare their transitive deps with ^.

Check out how we do this with exact versions and yarn resolutions here: anza-xyz/wallet-adapter@88f3576

This forces the resolved transitive deps to be pinned as well.

jordaaash · 2022-08-06T16:38:52Z

You'll know you did it right if you check your yarn.lock file and see only 6.27.1: https://github.com/solana-labs/wallet-adapter/blob/5437f957740e8651467b9eb74bf1d7ef77817f8f/yarn.lock#L1906-L1938

elbywan · 2022-08-09T10:30:46Z

So to sum it up.

Following this PR #364 @ledgerhq/device is now transpiled to commonjs and esm (in the /lib and /lib-es folders respectively).

Subpath exports have thus been added to use the same path (without /lib and /lib-es) in imports and allow consuming bundlers to declare which flavour of the dependency they want.

✅ For users of node.js@14+, webpack@5, esbuild, rollup, vite.js or any build tool that support subpath exports everything should be working fine.

⚠️ For users of other bundlers (parcel for instance - or webpack@4) you can either:

upgrade your bundler
configure your bundler to map @ledgerhq/devices to @ledgerhq/devices/lib-es (or @ledgerhq/devices/lib, depending if you want the commonjs or esm flavour).
use another bundler

With webpack@4 adding the following line to the config should make it work:

resolve: {
  alias: {
    "@ledgerhq/devices": "@ledgerhq/devices/lib-es",
  },
},

With parcel, adding an alias to the package.json:

"alias": {
  "@ledgerhq/devices": "@ledgerhq/devices/lib-es"
}

Bottom line, I do not see anything wrong in the library from what has been posted so far.

Users stuck with webpack@4 or using other bundlers can add a single configuration line to map to the right path, and other users should upgrade anyway (there are only a few breaking changes between v4 and v5 - released 2 years ago).

If I missed something and you think the problem comes from anything other than what I posted feel free to comment the issue.

Otherwise please follow the instructions above.

The following demonstrate that the lib works fine with a compatible bundler.

npx create-react-app hw-transport-webhid-test
cd hw-transport-webhid-test
npm i @ledgerhq/hw-transport-webhid buffer
Add the following code:

// src/App.js
import TransportWebHID from "@ledgerhq/hw-transport-webhid";
console.log(TransportWebHID);

// src/polyfill.js
import { Buffer } from "buffer";
window.Buffer = Buffer;

// src/index.js
import "./polyfill";

npm start

Builds and prints:

AlexeyAdoniev · 2022-08-09T15:47:30Z

Quick workaround for create-react-app(react-scripts v4) :

package.json

"dependencies": {
    "react-app-rewired": "^2.2.1",
  },

 "scripts": {
    "start": "react-app-rewired start",
    "build": "react-app-rewired build",
  },

config-overrides.js in root

module.exports = function override(webpackConfig) {
     
 webpackConfig.resolve.alias = {
    ...webpackConfig.resolve.alias,
    "@ledgerhq/devices/hid-framing": "@ledgerhq/devices/lib/hid-framing",
  };


}

ihorbond · 2022-08-09T19:07:20Z

Sounds like this should have been a breaking change, not just a minor patch.

elbywan · 2022-08-10T07:42:30Z

Sounds like this should have been a breaking change, not just a minor patch.

Yes, this is an oversight. @ledgerhq/devices did get a major bump but not the consuming hw-transport packages.

nebolsin · 2022-08-11T10:58:13Z

Just want to point out that the official Connecting an app tutorial uses parcel and is also broken now.

Adding parcel-style alias to the package.json seems to help:

{ 
  ...
  "alias": {
    "@ledgerhq/devices": "@ledgerhq/devices/lib-es"
  }
}

elbywan · 2022-08-11T12:23:14Z

@nebolsin Thanks, good catch 🙇 ! The tutorial needs to be updated.

@cfranceschi-ledger Sorry for the wild ping but I think you worked on this topic based on the file history. (cc: @fcipollone-ledger)

cfranceschi-ledger · 2022-08-11T13:30:18Z

Thank you @elbywan I will take this into account and modify the doc as soon as possible.

AmmarKhalid123 · 2022-08-20T07:58:11Z

Just a little correction in step 2:

config-overrides.js in root

module.exports = function override(webpackConfig) {
     
 webpackConfig.resolve.alias = {
    ...webpackConfig.resolve.alias,
    "@ledgerhq/devices/hid-framing": "@ledgerhq/devices/lib/hid-framing",
  };

 return webpackConfig;
}

landabaso · 2022-09-27T16:18:17Z

This also broke the metro bundler for react-native which does not support subpath exports (yet).

If anyone gets that problem, you need to update babel.config.js to:

module.exports = {
  presets: ['module:metro-react-native-babel-preset'],
  plugins: [
    [
      'module-resolver',
      {
        root: ['.'],
        alias: {
          '@ledgerhq/devices/hid-framing': '@ledgerhq/devices/lib/hid-framing',
        },
      },
    ],
  ],
};

Remember then to reset the cache before bulding it again: npm start -- --reset-cache

Related: facebook/metro#670

hbriese · 2023-08-02T12:13:33Z

This also broke the metro bundler for react-native which does not support subpath exports (yet).

If anyone gets that problem, you need to update babel.config.js to:
module.exports = {
  presets: ['module:metro-react-native-babel-preset'],
  plugins: [
    [
      'module-resolver',
      {
        root: ['.'],
        alias: {
          '@ledgerhq/devices/hid-framing': '@ledgerhq/devices/lib/hid-framing',
        },
      },
    ],
  ],
};
Remember then to reset the cache before bulding it again: npm start -- --reset-cache

Related: facebook/metro#670

As of react native 0.72 (expo 49) metro now supports package exports
The (beta) feature needs to be enabled in your metro config

dima-brook added bug Something isn't working libraries Impacts the Libraries labels Jul 28, 2022

elbywan added the invalid This doesn't seem right label Jul 29, 2022

elbywan mentioned this issue Aug 1, 2022

Can't find @ledgerhq/devices/hid-framing #799

Closed

dFohlen mentioned this issue Aug 3, 2022

Compile error: Module not found '@ledgerhq/devices/hid-framing' anza-xyz/wallet-adapter#499

Closed

gre mentioned this issue Aug 4, 2022

Module not found #842

Closed

Adamj1232 mentioned this issue Aug 8, 2022

[Bug]: Ledger integration error blocknative/web3-onboard#1201

Closed

1 task

elbywan closed this as completed Aug 9, 2022

kujtimprenkuSQA mentioned this issue Aug 19, 2022

Ledger Support Errors near/wallet-selector#411

Closed

elbywan mentioned this issue Sep 27, 2022

[Bug]: Cannot Find Module #1378

Closed

archseer added a commit to smartcontractkit/chainlink-solana that referenced this issue Nov 25, 2022

Fix jest tests (LedgerHQ/ledger-live#763)

9e623c1

archseer added a commit to smartcontractkit/chainlink-solana that referenced this issue Nov 25, 2022

Fix jest tests (LedgerHQ/ledger-live#763)

9b6ec84

valpinkman mentioned this issue Dec 12, 2022

[Bug]: Module not found: Error: Can't resolve '@ledgerhq/cryptoassets/data/eip712' #2084

Closed

alysiawu mentioned this issue Feb 16, 2023

fix ledger deps compound-finance/compound-components#78

Open

stevenkhong mentioned this issue Mar 21, 2023

[Bug] Error in react native 0.70.5 Switcheo/carbon-js-sdk#271

Closed

andreibancioiu mentioned this issue Jun 22, 2023

Use webpack instead of browserify. Reference newer HW-provider multiversx/mx-sdk-js-examples#23

Merged

JoeGruffins mentioned this issue Jul 4, 2023

multi: Add ledger ui. decred/decrediton#3874

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Module not found '@ledgerhq/devices/hid-framing' / https://registry.yarnpkg.com/@ledgerhq%2fdevices/hid-framing returned a 405 #763

Module not found '@ledgerhq/devices/hid-framing' / https://registry.yarnpkg.com/@ledgerhq%2fdevices/hid-framing returned a 405 #763

dima-brook commented Jul 28, 2022

gre commented Jul 28, 2022

dima-brook commented Jul 28, 2022 •

edited

Loading

gre commented Jul 28, 2022

elbywan commented Jul 29, 2022 •

edited

Loading

oleg-savenok commented Aug 2, 2022

jordaaash commented Aug 4, 2022

alihalabyah commented Aug 6, 2022

jordaaash commented Aug 6, 2022

jordaaash commented Aug 6, 2022

elbywan commented Aug 9, 2022 •

edited

Loading

AlexeyAdoniev commented Aug 9, 2022 •

edited

Loading

ihorbond commented Aug 9, 2022

elbywan commented Aug 10, 2022 •

edited

Loading

nebolsin commented Aug 11, 2022 •

edited

Loading

elbywan commented Aug 11, 2022 •

edited

Loading

cfranceschi-ledger commented Aug 11, 2022

AmmarKhalid123 commented Aug 20, 2022

landabaso commented Sep 27, 2022 •

edited

Loading

hbriese commented Aug 2, 2023

Module not found '@ledgerhq/devices/hid-framing' / https://registry.yarnpkg.com/@ledgerhq%2fdevices/hid-framing returned a 405 #763

Module not found '@ledgerhq/devices/hid-framing' / https://registry.yarnpkg.com/@ledgerhq%2fdevices/hid-framing returned a 405 #763

Comments

dima-brook commented Jul 28, 2022

gre commented Jul 28, 2022

dima-brook commented Jul 28, 2022 • edited Loading

gre commented Jul 28, 2022

elbywan commented Jul 29, 2022 • edited Loading

oleg-savenok commented Aug 2, 2022

jordaaash commented Aug 4, 2022

alihalabyah commented Aug 6, 2022

jordaaash commented Aug 6, 2022

jordaaash commented Aug 6, 2022

elbywan commented Aug 9, 2022 • edited Loading

So to sum it up.

AlexeyAdoniev commented Aug 9, 2022 • edited Loading

ihorbond commented Aug 9, 2022

elbywan commented Aug 10, 2022 • edited Loading

nebolsin commented Aug 11, 2022 • edited Loading

elbywan commented Aug 11, 2022 • edited Loading

cfranceschi-ledger commented Aug 11, 2022

AmmarKhalid123 commented Aug 20, 2022

landabaso commented Sep 27, 2022 • edited Loading

hbriese commented Aug 2, 2023

dima-brook commented Jul 28, 2022 •

edited

Loading

elbywan commented Jul 29, 2022 •

edited

Loading

elbywan commented Aug 9, 2022 •

edited

Loading

AlexeyAdoniev commented Aug 9, 2022 •

edited

Loading

elbywan commented Aug 10, 2022 •

edited

Loading

nebolsin commented Aug 11, 2022 •

edited

Loading

elbywan commented Aug 11, 2022 •

edited

Loading

landabaso commented Sep 27, 2022 •

edited

Loading