This repository has been archived by the owner on Jun 16, 2022. It is now read-only.
LL-8170 - exclude empty buttons generated by separator components #1993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LFBarreto
approved these changes
Nov 22, 2021
valpinkman
pushed a commit
that referenced
this pull request
Nov 22, 2021
* fix: use safe area views from react-native-safe-area-context (#1995) gets along better with react navigation, see https://reactnavigation.org/docs/handling-safe-area/ * fix: exclude empty buttons generated by separator components (#1993) * fix(router): add accounts route to AccountSettingsNavigator (#2000) * fix lint Co-authored-by: Julien Elbaz <[email protected]> Co-authored-by: J <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents "empty" buttons in the account page.
The issue arises when separator components are in the first 2 elements of the actions array they are converted into empty buttons.
Type
Bug Fix
Context
LL-8170
Parts of the app affected / Test plan