Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

allows for install when using commit hash in package.json deps #4791

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

valpinkman
Copy link
Member

🦒 Context (issues, jira)

To make sure yarn installs correctly in CI whenever we use a commit hash as dependency in package.json, we updated the CI. Context yarnpkg/yarn#7212 (comment)

Also updated some actions to prevent premature failing (like comment on PR)

🖤 Expectations to reach

PR must pass CI, rebase develop if conflicts. Thanks!

  • on QA: at least one of these two checkboxes must be checked:
    • a specific test planned is defined on Jira
    • this PR is covered by automatic UI test
  • on delivery: at least one of these two checkboxes must be checked:
    • Option 1: no impact: The changes of this PR have ZERO impact on the userland (invisible for users)
    • Option 2: atomic delivery: the changes is atomic and complete (no partial delivery)

@valpinkman valpinkman requested a review from a team February 25, 2022 17:13
@github-actions
Copy link

Thanks for your contribution.
To be able to merge in develop branch, you need to:

  • pass the CI
  • if needed, run /generate-screenshots
  • have a dev review
  • have a QA review
  • if needed, /upgrade-llc

Why /generate-screenshots ?

If your PR contains UI related changes,
it might be necessary to regenerate screenshots.

Why /upgrade-llc ?

If your PR requires an update to the ledger-live-common library,
once the PR is merged on develop on ledger-live-common side,
you need to run /upgrade-llc to switch back to ledger-live-common@develop here before merging.

@github-actions
Copy link

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 8.74% 9/103
🔴 Branches 0% 0/19
🔴 Functions 2.94% 1/34
🔴 Lines 8.33% 8/96

Test suite run success

1 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from da7de0f

@valpinkman valpinkman merged commit 0994b09 into develop Mar 2, 2022
@valpinkman valpinkman deleted the support/check-for-hash-commit branch March 2, 2022 11:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant