Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error thrown when client calls updateCurrentGistView the first time to create initial Gist #8

Closed
LearningNerd opened this issue Jun 28, 2017 · 0 comments
Closed

Error thrown when client calls updateCurrentGistView the first time to create initial Gist #8

LearningNerd opened this issue Jun 28, 2017 · 0 comments
Labels
bug
Milestone
Refactor and fix ...

Comments

@LearningNerd
Copy link
Member

LearningNerd commented Jun 28, 2017 •
edited
Loading

This is the mystery bug that appeared seemingly out of nowhere! The app was working fine and then the next time I tested it, this bug (among others) appeared even though I never changed the code!

Description of bug:

  • This bug only occurs the first time that updateCurrentGistView runs -- in other words, when creating the initial Gist when starting up the game.

  • “Uncaught TypeError: Cannot read property ‘url’ of undefined” at line 527 of local.js

Ideas for debugging:

  • After refactoring, check the flowchart and state diagram to see if anything seems wrong with the order of events.

  • Test the Gist creation in isolation (both for debugging and to build up more modular sample code for myself to practice with and build off of later)

  • Check if the GitHub API has changed since my last commit!
@LearningNerd LearningNerd changed the title Fix bug related to creating initial Gist Error thrown when client calls updateCurrentGistView the first time to create initial Gist Jun 28, 2017
LearningNerd added a commit that referenced this issue Jun 28, 2017
@LearningNerd
Merge pull request #22 from LearnTeachCode/issue8
fd57f8c 
Close #8, add updateCurrentGistView condition.

  - Client-side code now checks if turnData.gist exists before updating
the Gist view UI, inside handleUpdateState() and handleTurnChange()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Refactor and fix version 1.0.0
Development

No branches or pull requests
1 participant
@LearningNerd