Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change game start condition to check state of the player list #4

Closed
LearningNerd opened this issue Jun 28, 2017 · 0 comments
Closed

Comments

@LearningNerd
Copy link
Member

LearningNerd commented Jun 28, 2017

Currently, the server is checking if timerId is null to determine whether the game is in progress. But it would be more intuitive to check the player list; if there are players logged in, start the game! If not, stop the game.

Other options (which seem less intuitive) include:

  • Check if the turn index is null or -1 (but this seems unintuitive too!)
  • Use a gameRunning Boolean to track whether the game is in progress or not (but why create extra variables if I don't need them?
LearningNerd added a commit that referenced this issue Jul 3, 2017
Cloe #4, change game start condition to check state of the player list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant