Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send GitHub access token as a header, not as a URL parameter #15

Closed
LearningNerd opened this issue Jun 28, 2017 · 0 comments
Closed

Send GitHub access token as a header, not as a URL parameter #15

LearningNerd opened this issue Jun 28, 2017 · 0 comments
Labels
bug
Milestone
Refactor and fix ...

Comments

@LearningNerd
Copy link
Member

Because throwing the access token right into the URL is terrible for security! Look into how to access headers from client-side JavaScript. (Surely that must be possible!)
LearningNerd added a commit that referenced this issue Jul 11, 2017
@LearningNerd
Close #15, send GitHub access token via headers
e890598
@LearningNerd LearningNerd mentioned this issue Jul 11, 2017
Merged
LearningNerd added a commit that referenced this issue Jul 11, 2017
@LearningNerd
Merge pull request #34 from LearnTeachCode/issue15
24ef7e8 
Close #15, send GitHub access token via headers
LearningNerd added a commit that referenced this issue Jul 11, 2017
@LearningNerd
Revert "Close #15, send GitHub access token via headers"
9e52f6c
@LearningNerd LearningNerd mentioned this issue Jul 11, 2017
Merged
LearningNerd added a commit that referenced this issue Jul 11, 2017
@LearningNerd
Merge pull request #35 from LearnTeachCode/issue15
7d3b6e8 
Better solution for #15: simplify auth flow, more like Gatekeeper!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Refactor and fix version 1.0.0
Development

No branches or pull requests
1 participant
@LearningNerd