This repository has been archived by the owner on Sep 3, 2022. It is now read-only.
Improve git code cloning #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove directory while trying to clone code * Before removing we need to set files attributes to normal as git files refuse to be deleted
danil179
reviewed
Jun 15, 2021
| System.IO.DirectoryInfo cloningDir = new System.IO.DirectoryInfo(cloningPath); | ||
| // Set attributes in cloningDir to normal, as git files refuse to be deleted | ||
| setAttributesNormal(cloningDir); | ||
| cloningDir.Delete(true); |
There was a problem hiding this comment.
I suggest to ask the user with a warning message box, something like The folder {folderName} is already in use, are you sure you want to delete existing files?.
Another possibility is just to create a new folder GameServer2 and advance the number if the folder is in use.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove directory while trying to clone code
It allows to always run latest code from repos without issues.