Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add touch support for pointer based devices #2039

Closed
wants to merge 1 commit into from

Conversation

DanielX2
Copy link

Add touch support for pointer based devices like ie11 on Windows 8.1.

I tested these changes with following devices and browser:

  • Surface Pro with ie10(win8.0) and ie11(win.81)
  • Ipad Safari (IOS7)
  • Desktop with ie10, latest Chrome, latest opera, latest Firefox

At the moment I can't build the source file out of the repository, because I dont know the build process. (this is my first github Action)

@mourner
Copy link
Member

mourner commented Sep 20, 2013

You need to fix the whitespace so that I could see the diffs correctly (Leaflet uses hard tabs, not spaces).

Also, it seems that you wrote a new implementation of pointer events despite that we already have one here https://github.com/Leaflet/Leaflet/blob/master/src/dom/DomEvent.MsTouch.js — was there a particular reason?

Thanks!

@mourner
Copy link
Member

mourner commented Sep 20, 2013

Also, you can read how to set up the build process (and correspondingly fix the build errors) here: https://github.com/Leaflet/Leaflet/blob/master/CONTRIBUTING.md

@DanielX2
Copy link
Author

Sorry, i didn't see that my diffs are going trough the hole files, i will fix this and update it.

I thougth it would be better to implement a new handling, because i don't know if now and in future msPointer and pointer are working the same way.

Currently it seems as they would, but im not sure if they would do so if you want to implement new features. So i decided to do a new implementation.

But i could implement the pointer handling in the msPointer handling, if you want me to do this?

PS: Thanks for the link to the build process.

best regards

DanielX2

@mourner
Copy link
Member

mourner commented Oct 10, 2013

Closing in favor of #2066

@mourner mourner closed this Oct 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants