implement anvil and enchantment table inventorys #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new file: src/inventory/enchanting_table_inventory.rs modified: src/inventory/mod.rs modified: src/render/inventory.rs modified: src/server/mod.rs modified: src/ui/mod.rs
version of on_resize for all inventorys modified: protocol/src/types/mod.rs modified: src/inventory/anvil_inventory.rs modified: src/inventory/chest_inventory.rs modified: src/inventory/crafting_table_inventory.rs modified: src/inventory/dropper_inventory.rs modified: src/inventory/enchanting_table_inventory.rs modified: src/inventory/furnace_inventory.rs modified: src/inventory/mod.rs modified: src/inventory/player_inventory.rs modified: src/render/hud.rs
|
Is this still in work or did you just forget to un-draft it? |
modified: inventory/anvil_inventory.rs
|
yes, now it should be ready for review |
2 tasks
terrarier2111
requested changes
Feb 26, 2023
| pub enum Material { | ||
| Air, // 1.7.10 (id: 0, stack: 0)| 1.13 (id: 9648) | ||
| #[default] | ||
| Air, // 1.7.10 (id: 0, stack: 0)| 1.13 (id: 9648) |
There was a problem hiding this comment.
could you shift this comment back?
There was a problem hiding this comment.
I tried doing this already, but for some reason cargo fmt shifts this one line forward every time it is run.
| 0 => update_level_required(0, self), | ||
| 1 => update_level_required(1, self), | ||
| 2 => update_level_required(2, self), | ||
| 3 => (), |
There was a problem hiding this comment.
Could you add a comment explaining why this has no action associated with it?
| _ => warn!("the server sent invalid data for the enchanting table"), | ||
| } | ||
|
|
||
| // this fixes a bug in mc protocol |
There was a problem hiding this comment.
this is a bit vague, could you elaborate on that?
|
This is really cool, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inventorys are working at this stage but some of the code especially for the enchantment table is a mess. I will clean it up soon. If there are problems in the way i implemented these or bugs, let me know. This is some progress to #2