Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for grape version cascading #26

Conversation

qinix
Copy link

@qinix qinix commented Dec 16, 2016

Support API endpoints like so:

module API::V1
  class Root < Grape::API
    version [:v1, :v2], using: :path

    mount API::V1::Places
    mount API::V1::Users

    add_swagger_documentation api_version: 'v1', mount_path: '/docs'
  end
end

Use the first value in the array as the version component in url.

related issue

@LeFnord LeFnord force-pushed the prepare_for_ruby_2.4 branch 7 times, most recently from 1cdb1ac to e361f96 Compare December 18, 2016 14:08
@LeFnord
Copy link
Owner

LeFnord commented Dec 18, 2016

thanks @qinix for open the PR, is it ok for you if I take it over and cherry pick your work to make it mergeable?

@LeFnord LeFnord force-pushed the prepare_for_ruby_2.4 branch 2 times, most recently from ff9e186 to 6534b6c Compare December 18, 2016 14:50
@LeFnord
Copy link
Owner

LeFnord commented Dec 18, 2016

@qinix … for that I'll close this PR and cherry-pich your changes

@LeFnord LeFnord closed this Dec 18, 2016
@qinix
Copy link
Author

qinix commented Dec 18, 2016

@LeFnord 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants