Enhancement/warning reduction #172
Conversation
Kameeno
force-pushed
the
enhancement/Warning-reduction
branch
from
8311d63 to
d6d5db2
Compare
src/core/CoolBoardSensors.cpp
Outdated
| // Make sure sensors had enough time to turn on. | ||
| // BME280 requires 2ms to start up. | ||
| delay(1000); | ||
| DEBUG_VAR("BME280 status after begin is:", envSensorStatus); | ||
| DEBUG_VAR("BME280 status after begin is:", this->envSensor.begin()); |
There was a problem hiding this comment.
Ah, I don't think you should call begin() twice, sorry... What was the warning here ?
There was a problem hiding this comment.
is a warning when you compile in -e prod,
he say envSensorStatus is a unused variable
There was a problem hiding this comment.
No, we can't merge that and we need to find another solution to fix this. Isn't there a sensor.getStatus() method available on the BME class ?
src/extras/CoolAdafruit_CCS811.cpp
Outdated
| degrees; there is an offset: 0 maps to -25�C. The default value is | ||
| 25�C = 0x64, 0x00. As an example 23.5% temperature would be | ||
| degrees; there is an offset: 0 maps to -25�C. The default value is | ||
| 25�C = 0x64, 0x00. As an example 23.5% temperature would be |
There was a problem hiding this comment.
hmmmm those characters are weird ! Are they really responsible for warnings ?
There was a problem hiding this comment.
not, i don't know from where is coming this.
src/extras/CoolAdafruit_CCS811.cpp
Outdated
| @@ -86,8 +86,8 @@ void Adafruit_CCS811::setEnvironmentalData(uint8_t humidity, double temperature) | |||
| humidity would be 0x61, 0x00.*/ | |||
|
|
|||
| /* Temperature is stored as an unsigned 16 bits integer in 1/512 | |||
| degrees; there is an offset: 0 maps to -25�C. The default value is | |||
| 25�C = 0x64, 0x00. As an example 23.5% temperature would be | |||
| degrees; there is an offset: 0 maps to -25�C. The default value is | |||
Kameeno
force-pushed
the
enhancement/Warning-reduction
branch
3 times, most recently
from
24fb711 to
0e34425
Compare
| @@ -658,7 +658,7 @@ void CoolBoard::updateFirmware(String firmwareVersion, String firmwareUrl, | |||
| delete this->coolWifi; | |||
| INFO_LOG("Starting firmware update..."); | |||
| t_httpUpdate_return ret = | |||
| ESPhttpUpdate.update(firmwareUrl, "", firmwareUrlFingerprint, true); | |||
| ESPhttpUpdate.update(firmwareUrl, "", firmwareUrlFingerprint); | |||
There was a problem hiding this comment.
true is a boolean to indicate if need to reboot or not after the ota update, is true for default
src/core/CoolBoardSensors.cpp
Outdated
| // Make sure sensors had enough time to turn on. | ||
| // BME280 requires 2ms to start up. | ||
| delay(1000); | ||
| DEBUG_VAR("BME280 status after begin is:", envSensorStatus); | ||
| DEBUG_VAR("BME280 status after begin is:", this->envSensor.begin()); |
There was a problem hiding this comment.
No, we can't merge that and we need to find another solution to fix this. Isn't there a sensor.getStatus() method available on the BME class ?
| #include "CoolSDS011.h" | ||
| #include "SHT1x.h" |
Kameeno
force-pushed
the
enhancement/Warning-reduction
branch
from
0e34425 to
9ae9c11
Compare
Kameeno
force-pushed
the
enhancement/Warning-reduction
branch
from
9ae9c11 to
dae7581
Compare
No description provided.