fix: separate out validators who are awaiting activation queue #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
simulated what this looks like for the |
jbrower95
approved these changes
Aug 9, 2024
|
This also changes |
jbrower95
reviewed
Aug 9, 2024
| @@ -197,7 +201,7 @@ func SortByStatus(validators map[string]Validator) ([]Validator, []Validator, [] | |||
| return withdrawnValidators[i].Index < withdrawnValidators[j].Index | |||
| }) | |||
|
|
|||
| return inactiveValidators, activeValidators, withdrawnValidators | |||
| return awaitingActivationQueueValidators, inactiveValidators, activeValidators, withdrawnValidators | |||
There was a problem hiding this comment.
if you're gonna add a new return group to this function signature, i would probably put it at the end right?
There was a problem hiding this comment.
i was going for "lifecycle" here, since the left-most validators would occur earliest and then progress left to right
jbrower95
reviewed
Aug 9, 2024
| @@ -444,7 +466,8 @@ func SelectAwaitingCredentialValidators( | |||
| validatorInfo := validatorInfos[i] | |||
|
|
|||
| if (validatorInfo.Status == ValidatorStatusInactive) && | |||
| (validator.Validator.ExitEpoch == FAR_FUTURE_EPOCH) { | |||
| (validator.Validator.ExitEpoch == FAR_FUTURE_EPOCH) && | |||
| (validator.Validator.ActivationEpoch != FAR_FUTURE_EPOCH) { | |||
There was a problem hiding this comment.
this is the actual change, yeah?
jbrower95
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to core PR: Layr-Labs/eigenlayer-contracts#668