-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: adjust compendium for per-avs deployment #97
Merged
ChaoticWalrus
merged 29 commits into
m2-mainnet
from
feat-adjust-compendium-for-per-avs-deployment
Dec 13, 2023
Merged
Changes from 5 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
5159d3b
chore: copy BLSPublicKeyCompendium storage and functions into BLSApkR…
ChaoticWalrus 68f3817
chore: delete BLSPublicKeyCompendium and associated interface
ChaoticWalrus 1aa538d
feat: create harness for BLSApkRegistry and use it in tests
ChaoticWalrus f42ff73
chore: delete unused mock file
ChaoticWalrus 89d815a
chore: cleanup unused file and reduce mutability of test utils functions
ChaoticWalrus ec18a4c
feat: make BLSApkRegistry. registerBLSPublicKey only callable by Regi…
ChaoticWalrus 5a022ae
chore: remove `RegistryCoordinator.registerOperator` method without p…
ChaoticWalrus 11c51e1
feat: create struct for pubkey registration params
ChaoticWalrus da6f3a5
fix: address stack-too-deep issue in RegistryCoordinator
ChaoticWalrus 9948e01
chore: delete unused index
ChaoticWalrus db00092
feat: optimization for fetching operatorId
ChaoticWalrus da59eee
chore: shorten variable name that is quite clear from context
ChaoticWalrus ffc25f7
Merge pull request #100 from Layr-Labs/feat-combined-operator-registr…
ChaoticWalrus 630b27d
feat: use EIP712 for the pubkeyRegistrationMessageHash
ChaoticWalrus ef7147f
chore: add NatSpec to getter function
ChaoticWalrus e2e8b6a
Merge pull request #102 from Layr-Labs/chore-cleanup-for-compendium-c…
ChaoticWalrus 789f568
Merge branch 'm2-mainnet' of https://github.com/Layr-Labs/eigenlayer-…
ChaoticWalrus a47ee2b
chore: fix merge artifacts / broken calls
ChaoticWalrus 0db5eb5
chore: re-implement stack-too-deep fix
ChaoticWalrus 891a219
chore: de-duplicate code into an internal function
ChaoticWalrus 1e27ee5
fix: actually use the `operator` input to `_getOrCreateOperatorId`
ChaoticWalrus e729464
feat: add optimizer runs count to foundry config
ChaoticWalrus 43ed474
chore: remove redundant check and return data
ChaoticWalrus b205bde
chore: fewer memory operations(?)
ChaoticWalrus c2f5719
fix: reduce optimizer runs to meet contract code size limits
ChaoticWalrus caf9960
chore: rename file to reflect it only being used in tests
ChaoticWalrus b659b2f
chore: delete unused (memory) variable
ChaoticWalrus d03039f
fix: have the harness import Test so it gets ignored in build sizes
wadealexc 05402be
Merge pull request #105 from Layr-Labs/fix-address-contract-code-size…
ChaoticWalrus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably change the message hash "EigenLayer_BN254_Pubkey_Registration" to something that's more AVS specific, or just remove entirely since there won't be a singleton compendium contract anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, perhaps we can just delete the
EigenLayer_
part?it's overkill to have this at all, but it's another input to help protect from any kind of replay issues, so...I feel like it's not a bad idea to have some string here at least.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
realized I should probably just convert this to use EIP-712 instead; will add that to my TODOs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed as part of #102 -- I think these changes are quite appropriate