Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update nonSignerForQuorumIndex outside of loop #65

Merged
merged 2 commits into from
Nov 16, 2023
Merged

update nonSignerForQuorumIndex outside of loop #65

merged 2 commits into from
Nov 16, 2023

Conversation

gpsanant
Copy link
Contributor

@gpsanant gpsanant commented Nov 16, 2023 •
edited
Loading

fixes a bug where the first nonSignerStakeIndex is used for all non signers

ChaoticWalrus
ChaoticWalrus approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@ChaoticWalrus ChaoticWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good commit! We should add a regression test for this bug as well, but that can go in another PR.

@gpsanant gpsanant marked this pull request as ready for review November 16, 2023 17:53
@gpsanant gpsanant merged commit d5d520e into master Nov 16, 2023
2 of 3 checks passed
@gpsanant gpsanant deleted the fix-loop-reset-nonSignerForQuorumIndex branch November 16, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChaoticWalrus ChaoticWalrus ChaoticWalrus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gpsanant @ChaoticWalrus