Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate Prover functionality from core repo #4

Closed
wants to merge 14 commits into from

Conversation

ChaoticWalrus
Copy link
Contributor

had to modify some paths / folder structure / etc

Marking this PR as a draft for the moment, as it's currently having compiler issues due to duplicate instances of IPauserRegistry.sol.

@stevennevins
Copy link
Collaborator

@ChaoticWalrus is this good to move out of draft status?

@ChaoticWalrus
Copy link
Contributor Author

@ChaoticWalrus is this good to move out of draft status?

I marked it as a draft since it wasn't compiling / I didn't want to add to the list of these things to sort out. I'll take 15min and see if I can get it to run now after pulling from master.

@ChaoticWalrus
Copy link
Contributor Author

hmm, @stevennevins I'm happy to have you take a look but am still struggling here.
The compiler doesn't seem to be playing nicely with the file/import structure (see https://github.com/Layr-Labs/eigenlayer-middleware/actions/runs/6591010121/job/17908751745?pr=4#step:9:24) -- feeling like this could maybe be a remappings issue but I didn't have any luck solving this locally

@stevennevins
Copy link
Collaborator

Looks like a remapping issue. Adding a remappings.txt or a remappings list in the foundry.toml might resolve

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be empty?

RULE="--rule $2"
fi

solc-select use 0.8.12
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed in the action trace you shared this command wasn't found

@stevennevins
Copy link
Collaborator

Looks like a remapping issue. Adding a remappings.txt or a remappings list in the foundry.toml might resolve

It's probably not remapping-related now that I took more of a look. There might be some setup piece that isn't correct or path in the config that isn't correct with the slightly different directory structure

@ChaoticWalrus
Copy link
Contributor Author

Looks like a remapping issue. Adding a remappings.txt or a remappings list in the foundry.toml might resolve

It's probably not remapping-related now that I took more of a look. There might be some setup piece that isn't correct or path in the config that isn't correct with the slightly different directory structure

Yeah, my bad, scripts need to also list the remappings and I missed one for 'eigenlayer-contracts'. CI should be running now but it's possible the rule still fails -- we'll see!

we were using the wrong syntax, resulting in listing scripts twice instead of once
@ChaoticWalrus
Copy link
Contributor Author

So this is now running as well as it was in the other repo.
The existing rules are failing, but due to 'havoc' behavior which really shouldn't be present, given the dispatching behavior defined in the spec.
We can merge this but it'll result in a failing CI for the moment, so... I'm fine either way 🤷

@ChaoticWalrus
Copy link
Contributor Author

closing this PR as stale; if these rules are added, it should be in a new PR

@stevennevins stevennevins deleted the add-certora-rules branch November 25, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants