Gas Analysis: StakeRegistry.updateStakes() setup as a cronjob #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+968
to
+972
| for (uint j = 0; j < stakesForQuorum.length; j++) { | ||
| stakeRegistry.setOperatorWeight(uint8(quorumNumbers[j]), defaultOperator, stakesForQuorum[j] + 1); | ||
| } | ||
|
|
||
| updateOperators[i] = operators[i]; |
There was a problem hiding this comment.
this looks like it's repeatedly setting the weight just for the defaultOperator?
There was a problem hiding this comment.
oh, but defaultOperator = operators[i]; above. never mind, just confusing naming
There was a problem hiding this comment.
Yeah, carried over some of the logic from existing tests so not the cleanest at the moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We want to get some gas cost estimates for performing a weekly running cronjob that performs stake updates for
operators. Assuming ~200 operators, and varying quorums, this action would probably have to be batched into multiple update calls.