Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Consistently Indicate Slasher Under Development and Inactive #36

Merged
merged 10 commits into from
Nov 3, 2023

Conversation

stevennevins
Copy link
Collaborator

@stevennevins stevennevins commented Oct 27, 2023

per Sam's feedback #27

Copy link
Contributor

@ChaoticWalrus ChaoticWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit on wording, otherwise looks good-to-go

@samlaf
Copy link
Contributor

samlaf commented Oct 27, 2023

@stevennevins @ChaoticWalrus just realized, can we also add a note above freezeOperator() in IServiceManager.sol saying that this is only a temporary placeholder, and shouldnt actually be implemented to call the slasher for now.

@stevennevins stevennevins merged commit 384a4e4 into master Nov 3, 2023
2 of 3 checks passed
@stevennevins stevennevins deleted the docs/consistent-slasher-notes branch November 3, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants