Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix typos and add note that large array may cause revert #323

Merged
merged 1 commit into from
Dec 5, 2024
Merged

docs: fix typos and add note that large array may cause revert #323

merged 1 commit into from
Dec 5, 2024

Conversation

nadir-akhtar
Copy link

This PR addresses informational findings for the Rewards v2 internal security review. Specifically, this PR:

  • Changes callabe to callable in various comments
  • Adds a note that a large submissions array may result in hitting the gas limit, and to reattempt with a smaller array if so

@nadir-akhtar nadir-akhtar changed the base branch from mainnet to dev November 27, 2024 20:27
@nadir-akhtar nadir-akhtar merged commit 91400d9 into dev Dec 5, 2024
3 checks passed
@nadir-akhtar nadir-akhtar deleted the nadir/rewards-v2 branch December 5, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xrajath 0xrajath 0xrajath approved these changes

@stevennevins stevennevins stevennevins left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nadir-akhtar @stevennevins @0xrajath