Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: minor typos in iservicemanager #278

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Fix: minor typos in iservicemanager #278

merged 1 commit into from
Jun 25, 2024

Conversation

samlaf
Copy link
Contributor

@samlaf samlaf commented Jun 25, 2024

No description provided.

@samlaf samlaf changed the base branch from mainnet to dev June 25, 2024 21:00
ChaoticWalrus
ChaoticWalrus approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@ChaoticWalrus ChaoticWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good correction. is this already fixed in the contract and was just messed up in the interface?

@samlaf
Copy link
Contributor Author

samlaf commented Jun 25, 2024

good correction. is this already fixed in the contract and was just messed up in the interface?

Yes I didn’t even see mentions of delegationmanagee in service manager base

@samlaf samlaf merged commit d643f3b into dev Jun 25, 2024
3 checks passed
@samlaf samlaf deleted the fix-typos-in-iservicemanager branch June 25, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChaoticWalrus ChaoticWalrus ChaoticWalrus approved these changes

@stevennevins stevennevins stevennevins approved these changes

@8sunyuan 8sunyuan Awaiting requested review from 8sunyuan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samlaf @stevennevins @ChaoticWalrus