Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vm assume too many rejections #247

Merged
merged 3 commits into from
Apr 29, 2024
Merged

fix: vm assume too many rejections #247

merged 3 commits into from
Apr 29, 2024

Conversation

stevennevins
Copy link
Collaborator

No description provided.

@stevennevins stevennevins self-assigned this Apr 29, 2024
Comment on lines 804 to 994
cheats.assume(blockGap < 100);
numRegistrants = bound(numRegistrants, 1, 100);
blockGap = bound(blockGap, 0, 10);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason for switching the upper bound here to 10 from 100?
seems fine either way tho

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch that was a typo

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@ChaoticWalrus ChaoticWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I commented on the two actual changes I see -- everything else is formatting.

@stevennevins stevennevins merged commit 1703d25 into dev Apr 29, 2024
3 checks passed
@stevennevins stevennevins deleted the fix/bound-inputs branch April 29, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants