Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: service manager payments #242

Merged
merged 4 commits into from
Apr 23, 2024
Merged

feat: service manager payments #242

merged 4 commits into from
Apr 23, 2024

Conversation

8sunyuan
Copy link
Collaborator

Adds the function submitRangePayments to the ServiceManagerBase contract which allows the ServiceManager owner
to submit RangePayments to the PaymentCoordinator. Note that the owner must have already approved the ServiceManager contract for the payment tokens they are submitting.
Includes interface changes as well to be more explicit on the UI required interfaces.

@8sunyuan 8sunyuan requested review from samlaf and ypatil12 April 22, 2024 16:12
Copy link
Contributor

@samlaf samlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for separating IServiceManagerUI into its own separate interface. I only reviewed the src contracts (not tests), lgtm! Added some small nitpick comments.

src/ServiceManagerBase.sol Outdated Show resolved Hide resolved
src/ServiceManagerBase.sol Outdated Show resolved Hide resolved
src/ServiceManagerBase.sol Outdated Show resolved Hide resolved
src/interfaces/IServiceManagerUI.sol Outdated Show resolved Hide resolved
Copy link
Contributor

@samlaf samlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quick changes. LGTM now. I'll approve even though 2 tests are failing and should be fixed, and someone else should review the tests.

@8sunyuan 8sunyuan merged commit e18c19e into dev Apr 23, 2024
2 of 3 checks passed
@8sunyuan 8sunyuan deleted the service-manager-payments branch April 23, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants