Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organize and clean up file and function layout #2

Merged
merged 7 commits into from
Oct 18, 2023
Merged

Organize and clean up file and function layout #2

merged 7 commits into from
Oct 18, 2023

Conversation

wadealexc
Copy link
Collaborator

@wadealexc wadealexc commented Oct 18, 2023 •
edited
Loading

  • Places methods in external -> internal -> view order, consistent with our other repo
  • Splits function definitions and internal function calls onto multiple lines where needed
  • Removed unused before/after hooks
  • Removed unused "non-view" method that just called a view method

@wadealexc wadealexc changed the title Place functions in external -> internal -> view order, consistent wit… Organize and clean up file and function layout Oct 18, 2023
@wadealexc wadealexc merged commit 5b1b729 into master Oct 18, 2023
1 of 2 checks passed
@wadealexc wadealexc deleted the alex/reorder-functions branch October 18, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevennevins stevennevins stevennevins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wadealexc @stevennevins