Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git pulled eigenlayer-contract@master #14

Merged
merged 3 commits into from
Oct 20, 2023

Conversation

samlaf
Copy link
Contributor

@samlaf samlaf commented Oct 19, 2023

Is this fine? I need to refer to the cleaned up deploy script that just got merged in eigenlayer-contract master.

Not sure if this breaks other things though. Not even sure which commit we were originally pointing to. Seemed to not be a commit on master?

@ChaoticWalrus
Copy link
Contributor

Looks like the compiler is erroring out with is at the moment due to @Sidu28 merging this PR Layr-Labs/eigenlayer-contracts#262
Right now the 'EigenLayerTestHelper' is duplicated in this repo from the core repo (see here https://github.com/Layr-Labs/eigenlayer-contracts/blob/master/src/test/EigenLayerTestHelper.t.sol vs https://github.com/Layr-Labs/eigenlayer-middleware/blob/samlaf/git-pull-eigenlayer-contract/test/EigenLayerTestHelper.t.sol)
We should probably just de-dupe this, so we don't end up having to maintain it in 2 places?

@samlaf
Copy link
Contributor Author

samlaf commented Oct 19, 2023

@ChaoticWalrus removed the duplicate test from this repo. Test will still need to be fixed in eigenlayer-contracts though of course.

Copy link
Contributor

@ChaoticWalrus ChaoticWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, thanks for sorting this out.

@ChaoticWalrus ChaoticWalrus merged commit 760a518 into master Oct 20, 2023
1 check passed
@ChaoticWalrus ChaoticWalrus deleted the samlaf/git-pull-eigenlayer-contract branch October 20, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants