update pairing failed msg in pubkeycompendium #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaoticWalrus
requested changes
Oct 19, 2023
the parenthetical just made the message too damn long (sorry @samlaf !) -- otherwise this commit is just fixing the failing tests
ChaoticWalrus
approved these changes
Oct 19, 2023
|
Thanks Jeff!! Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Registration was failing because we hadn't update the eigensdk to also add the compendium's address in the msg being signed, but we were still getting a "G1 and G2 private key do not match", which was confusing.
This PR fixes the error msg.