feat: add share helpers #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8sunyuan
reviewed
Dec 18, 2024
8sunyuan
reviewed
Dec 18, 2024
| } | ||
|
|
||
| // get the deposit shares | ||
| uint256[] memory oneThirdWithdrawableShares = new uint256[](strategies.length); |
There was a problem hiding this comment.
Not quite sure why this is being done here in the helper
There was a problem hiding this comment.
it's just to make sure the thing properly scales down as well when called with smaller values that the max amount of shares
gpsanant
force-pushed
the
gpsanant/add-share-helpers
branch
from
36e8a85 to
471497a
Compare
8sunyuan
approved these changes
Dec 18, 2024
ypatil12
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a view func for converting deposit shares from withdrawable shares