fix: operator split activation delay lock #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xrajath
commented
Dec 12, 2024
ypatil12
approved these changes
Dec 12, 2024
ypatil12
reviewed
Dec 12, 2024
gpsanant
approved these changes
Dec 12, 2024
seanmcgary
added a commit
to Layr-Labs/sidecar
that referenced
this pull request
Dec 18, 2024
# Motivation Fixing the audit recommendations in https://docs.google.com/document/d/1b7kw5UWkfLYE-aOW6n6-jq_tazwR06LRZRlFV3AUCfg/edit?tab=t.0 # Modifications 1. Proper end time calculation for split snapshots 2. Remove overlapping split edge case (Fixed in the core protocol in Layr-Labs/eigenlayer-contracts#947) # Result Rewards v2 Test Case passing: <img width="647" alt="Screenshot 2024-12-17 at 8 08 21 PM" src="https://github.com/user-attachments/assets/958e0512-39fe-4b2f-ad9e-afdcb76c4079" />
seanmcgary
added a commit
to Layr-Labs/sidecar
that referenced
this pull request
Dec 20, 2024
# Motivation Fixing the audit recommendations in https://docs.google.com/document/d/1b7kw5UWkfLYE-aOW6n6-jq_tazwR06LRZRlFV3AUCfg/edit?tab=t.0 # Modifications 1. Proper end time calculation for split snapshots 2. Remove overlapping split edge case (Fixed in the core protocol in Layr-Labs/eigenlayer-contracts#947) # Result Rewards v2 Test Case passing: <img width="647" alt="Screenshot 2024-12-17 at 8 08 21 PM" src="https://github.com/user-attachments/assets/958e0512-39fe-4b2f-ad9e-afdcb76c4079" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a lock on the activation delay for operator splits to ensure that an operator's existing split has to activate before that operator can set the split again.