chore: dev into testnet-holesky #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpsanant
reviewed
Jun 5, 2024
| @@ -195,19 +195,6 @@ contract StrategyManager is | |||
| strategy.withdraw(recipient, token, shares); | |||
| } | |||
|
|
|||
| /// @notice Function called by the DelegationManager as part of the process of transferring existing queued withdrawals from this contract to that contract. | |||
| /// @dev This function is expected to be removed in the next upgrade, after all queued withdrawals have been migrated. | |||
| function migrateQueuedWithdrawal(DeprecatedStruct_QueuedWithdrawal memory queuedWithdrawal) external onlyDelegationManager returns(bool, bytes32) { | |||
There was a problem hiding this comment.
if this isn't on testnet are we ok making the release?
There was a problem hiding this comment.
This function doesn't get called regardless because we redeployed onto Holesky last minute for M2. We never had version of M1 contracts.
Can queue multisig txs after to upgrade the SM and DM to be accurate with this branch
wadealexc
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging
devfor the testnet Holesky Rewards releaseRelease tag after merging will be
v0.3.0-holesky-rewards