build: script for public holesky testnet #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
gpsanant
reviewed
Jun 4, 2024
gpsanant
reviewed
Jun 4, 2024
| "EIGENImpl": "0x083bC9e0DCF2C3e13E24686e5202232995578c5a", | ||
| "bEIGENImpl": "0x4500927874Ad41538c1bEF2F5278E7a86DF6bce8", | ||
| "eigenStrategy": "0x43252609bff8a13dFe5e057097f2f45A24387a84", | ||
| "eigenStrategyImpl": "0x94650e09a471CEF96e7966cabf26718FBf352697" |
There was a problem hiding this comment.
why is all of this token stuff added?
There was a problem hiding this comment.
This was needed to fix the deploy scripts since you added the token address checks to the ExistingDeploymentParser script helper
gpsanant
reviewed
Jun 4, 2024
| @@ -45,7 +45,16 @@ | |||
| "strategyManager": "0xdfB5f6CE42aAA7830E94ECFCcAd411beF4d4D5b6", | |||
| "strategyManagerImplementation": "0x59f766A603C53f3AC8Be43bBe158c1519b193a18", | |||
| "rewardsCoordinator": "0x0000000000000000000000000000000000000000", | |||
| "rewardsCoordinatorImplementation": "0x0000000000000000000000000000000000000000" | |||
| "rewardsCoordinatorImplementation": "0x0000000000000000000000000000000000000000", | |||
There was a problem hiding this comment.
are you question marking the diff here? the whole line is marked as a diff because a comma was added at the end :D
gpsanant
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script being used will be
Deploy_Test_RewardsCoordinator.s.solfor deployment.The main thing to review are the config values under
Deploy_RewardsCoordinator.holesky.config.json