feat: better introspection for encumbered magnitude #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wadealexc
force-pushed
the
alex/alm-magnitude-introspect
branch
2 times, most recently
from
bc82389 to
03e41ea
Compare
wadealexc
force-pushed
the
alex/alm-magnitude-introspect
branch
from
03e41ea to
321ff35
Compare
wadealexc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning: current
encumberedMagnitudeis a public getter that returns the non-updated version of an operator's encumbered magnitude.When actually calling
modifyAllocations, we use the updated version -- so this is probably more relevant to expose.This PR makes the
encumberedMagnitudemappinginternal, and instead exposes a getter (getEncumberedMagnitude) that returns the current encumbered magnitude with completable deallocations included.