Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: non-beacon-chain slashing integration tests #1010

Merged
merged 10 commits into from
Jan 14, 2025

Conversation

eigenmikem
Copy link

No description provided.

eigenmikem and others added 4 commits January 9, 2025 13:05
* Validate that users who are slashed fully can redeposit once undelegated

* removing arraylib use

* test for updating eigenpod state -> slash/undelegate

* removing unnecessary logging function

* fixing strategy set

* beacon chain tests in progress

---------

Co-authored-by: Michael <[email protected]>
@eigenmikem eigenmikem requested a review from ypatil12 January 9, 2025 22:30
Copy link
Collaborator

@ypatil12 ypatil12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need CI Passing :)

Copy link
Collaborator

@ypatil12 ypatil12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add an additional case!

Edit: Based on the new bug fix

@wadealexc wadealexc force-pushed the slashing-magnitudes-fixes branch from 1427a85 to 403e0a1 Compare January 13, 2025 19:58
Copy link
Collaborator

@ypatil12 ypatil12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 172 to 173
for (uint256 i = 0; i < expectedTokens.length; i++) {
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stub?

@wadealexc wadealexc changed the title Non-Beacon Chain slashing integration tests test: non-beacon-chain slashing integration tests Jan 14, 2025
@wadealexc
Copy link
Collaborator

Updated PR title so it will pass commitlint checks when merged

Copy link
Collaborator

@wadealexc wadealexc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine after comments are addressed. Will approve now so I don't block :)

@eigenmikem eigenmikem merged commit 3802dec into slashing-magnitudes-fixes Jan 14, 2025
11 checks passed
@eigenmikem eigenmikem deleted the slashing-integration-erc20 branch January 14, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants