-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: non-beacon-chain slashing integration tests #1010
test: non-beacon-chain slashing integration tests #1010
Conversation
* Validate that users who are slashed fully can redeposit once undelegated * removing arraylib use * test for updating eigenpod state -> slash/undelegate * removing unnecessary logging function * fixing strategy set * beacon chain tests in progress --------- Co-authored-by: Michael <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just need CI Passing :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add an additional case!
Edit: Based on the new bug fix
src/test/integration/tests/Deposit_Delegate_Allocate_Slash_Queue_Redeposit.t.sol
Show resolved
Hide resolved
* fix: fixing 0 withdrawal issues * style: white space * docs: changing description for test --------- Co-authored-by: Michael <[email protected]>
1427a85
to
403e0a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/test/integration/tests/Deposit_Delegate_Allocate_Slash_Queue_Redeposit.t.sol
Outdated
Show resolved
Hide resolved
for (uint256 i = 0; i < expectedTokens.length; i++) { | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stub?
src/test/integration/tests/Deposit_Delegate_Allocate_Slash_Queue_Redeposit.t.sol
Outdated
Show resolved
Hide resolved
Updated PR title so it will pass commitlint checks when merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine after comments are addressed. Will approve now so I don't block :)
No description provided.