[1/N] Batch transactor: wait for n confirmations for a transaction #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
force-pushed
the
txn-confirmations
branch
6 times, most recently
from
3853fe3
to
ef08bf1
Compare
ian-shim
changed the title
ian-shim
force-pushed
the
txn-confirmations
branch
3 times, most recently
from
222babe
to
c9e4fe1
Compare
ian-shim
changed the title
mooselumph
approved these changes
Dec 13, 2023
| @@ -31,6 +32,7 @@ type EthClient struct { | |||
| NoSendTransactOpts *bind.TransactOpts | |||
| Contracts map[gethcommon.Address]*bind.BoundContract | |||
| Logger common.Logger | |||
| numConfirmations int | |||
| } | |||
There was a problem hiding this comment.
Do you think this is this is generally a global setting or would it be something that would vary between different types of calls?
There was a problem hiding this comment.
I think this should be something each component sets globally and hidden from callers for now, although i can see there may be a need to override for different types of calls in the future if we have a lot more different types of calls.
ian-shim
force-pushed
the
txn-confirmations
branch
from
c9e4fe1
to
b5c0b1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently, transactor assumes a transaction is successful as soon as transaction receipt is available without waiting for any confirmations.
This PR adds a way to wait for a specified number of confirmations.
Checks