Clean up unused node methods #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mooselumph
reviewed
Nov 8, 2024
api/proto/node/node.proto
Outdated
| @@ -18,9 +18,11 @@ service Dispersal { | |||
| // StoreBlobs is simiar to StoreChunks, but it stores the blobs using a different storage schema | |||
| // so that the stored blobs can later be aggregated by AttestBatch method to a bigger batch. | |||
| // StoreBlobs + AttestBatch will eventually replace and deprecate StoreChunks method. | |||
| // DEPRECATED: StoreChunks method is not used | |||
There was a problem hiding this comment.
nit: StoreBlobs method is not used
mooselumph
approved these changes
Nov 8, 2024
ian-shim
force-pushed
the
cleanup-node-minibatch-rpc
branch
from
5a20dd2 to
8e9a592
Compare
jianoaix
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Removing unused minibatch related codepath from node
Checks