Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verifyBlobs util #862

Merged
merged 3 commits into from
Nov 18, 2024
Merged

verifyBlobs util #862

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4fde496
batched verify blob
0x0aa0 Nov 4, 2024
f1434a0
unit test
0x0aa0 Nov 7, 2024
0405bbe
internal funcs
0x0aa0 Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions contracts/src/libraries/EigenDARollupUtils.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ library EigenDARollupUtils {
* @param blobVerificationProof the relevant data needed to prove inclusion of the blob and that the trust assumptions were as expected
*/
function verifyBlob(
IEigenDAServiceManager.BlobHeader calldata blobHeader,
IEigenDAServiceManager.BlobHeader memory blobHeader,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why cant we keep this calldata?

IEigenDAServiceManager eigenDAServiceManager,
BlobVerificationProof calldata blobVerificationProof
) external view {
BlobVerificationProof memory blobVerificationProof
) internal view {
require(
EigenDAHasher.hashBatchMetadata(blobVerificationProof.batchMetadata)
== eigenDAServiceManager.batchIdToBatchMetadataHash(blobVerificationProof.batchId),
Expand Down Expand Up @@ -104,10 +104,10 @@ library EigenDARollupUtils {
* @param blobVerificationProofs the relevant data needed to prove inclusion of the blobs and that the trust assumptions were as expected
*/
function verifyBlobs(
IEigenDAServiceManager.BlobHeader[] calldata blobHeaders,
IEigenDAServiceManager.BlobHeader[] memory blobHeaders,
IEigenDAServiceManager eigenDAServiceManager,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this the first param imo

BlobVerificationProof[] calldata blobVerificationProofs
) external view {
BlobVerificationProof[] memory blobVerificationProofs
) internal view {
require(blobHeaders.length == blobVerificationProofs.length, "EigenDARollupUtils.verifyBlobs: blobHeaders and blobVerificationProofs must have the same length");

bytes memory quorumAdversaryThresholdPercentages = eigenDAServiceManager.quorumAdversaryThresholdPercentages();
Expand Down Expand Up @@ -184,7 +184,7 @@ library EigenDARollupUtils {
function getQuorumAdversaryThreshold(
IEigenDAServiceManager eigenDAServiceManager,
uint256 quorumNumber
) public view returns(uint8 adversaryThresholdPercentage) {
) internal view returns(uint8 adversaryThresholdPercentage) {
if(eigenDAServiceManager.quorumAdversaryThresholdPercentages().length > quorumNumber){
adversaryThresholdPercentage = uint8(eigenDAServiceManager.quorumAdversaryThresholdPercentages()[quorumNumber]);
}
Expand Down
Loading