Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert threshold update #854

Closed
wants to merge 1 commit into from
Closed

revert threshold update #854

wants to merge 1 commit into from

Conversation

0x0aa0
Copy link
Contributor

@0x0aa0 0x0aa0 commented Oct 31, 2024

Why are these changes needed?

reverts threshold update breaking CI

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@0x0aa0 0x0aa0 requested a review from ian-shim October 31, 2024 20:53
ian-shim
ian-shim requested changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@ian-shim ian-shim left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can close this now. #855 should fix the test

@0x0aa0 0x0aa0 closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ian-shim ian-shim ian-shim requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x0aa0 @ian-shim