Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(disperser-client): RetrieveBlob grpc max size regression bug #849

Merged
merged 6 commits into from
Oct 31, 2024
Merged

fix(disperser-client): RetrieveBlob grpc max size regression bug #849

merged 6 commits into from
Oct 31, 2024

Commits on Oct 30, 2024

  1. fix(disperser-client): RetrieveBlob max size regression bug 

    A previous commit 6894828 (#826) caused regression by forgetting to set grpc max msg size in retrieveBlob call

Caught by integration test from eigenda-proxy

Added unit-test here to catch any future regression on this feature
    @samlaf
    samlaf committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    6245212 View commit details
    Browse the repository at this point in the history

  2. docs: clearer MaxRetrieveBlobSizeBytes docstring

    @samlaf
    samlaf committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    76bed5f View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. style(disperser_client): move setting MaxRetrieveBlobSizeBytes defaul… 

    …t value to constructor
    @samlaf
    samlaf committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    04499a5 View commit details
    Browse the repository at this point in the history

  2. revert(disperser-client): move back to previous convention disperserC… 

    …lient(struct)/DisperserClient(interface) to prevetn breaking change
    @samlaf
    samlaf committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    dc98581 View commit details
    Browse the repository at this point in the history

  3. docs: add todo to rename eigenDAClient to follow disperserClient conv… 

    …ention
    @samlaf
    samlaf committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    57d716f View commit details
    Browse the repository at this point in the history

  4. fix(disperser-client): make constructor return err when config is wrong

    @samlaf
    samlaf committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    f2100c8 View commit details
    Browse the repository at this point in the history