Replace math/rand with crypto/rand for generating challenge
#829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anupsv
reviewed
Oct 23, 2024
| s.metrics.HandleInvalidArgRequest("DisperseBlobAuthenticated") | ||
| return api.NewInvalidArgError(fmt.Sprintf("failed to generate challenge: %v", err)) | ||
| } | ||
| challenge := binary.LittleEndian.Uint32(challengeBytes) |
There was a problem hiding this comment.
any preference to little or big endian
There was a problem hiding this comment.
I don't think that matters much here as we're converting one random byte array into uint32
anupsv
approved these changes
Oct 23, 2024
ian-shim
added a commit
to ian-shim/eigenda
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Using
crypto/randto generate challenge for disperser endpointChecks