Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose public ip service option on node plugin #756

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Expose public ip service option on node plugin #756

merged 1 commit into from
Sep 10, 2024

Conversation

pschork
Copy link
Contributor

@pschork pschork commented Sep 10, 2024

Why are these changes needed?

The default public ip lookup service is seeip (which is currently having an outage)

curl 'https://api.seeip.org/jsonip?'
<html>
<head><title>502 Bad Gateway</title></head>
<body>
<center><h1>502 Bad Gateway</h1></center>
<hr><center>nginx/1.18.0 (Ubuntu)</center>
</body>
</html>

If you change the ip lookup service in .env

# TODO: The ip provider service used to obtain a node's public IP [seeip (default), ipify)
NODE_PUBLIC_IP_PROVIDER=ipify

the node plugin continues to use seeip because the cmdline arg is not wired up.

This change fixes that.

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@pschork pschork merged commit 53ab26d into master Sep 10, 2024
10 checks passed
jianoaix pushed a commit that referenced this pull request Sep 12, 2024
@pschork @jianoaix
Expose public ip service option on node plugin (#756)
354e030
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianoaix jianoaix jianoaix approved these changes

@ian-shim ian-shim Awaiting requested review from ian-shim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pschork @jianoaix