Fix encoding queue limit test #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
requested review from
mooselumph,
jianoaix and
wmb-software-consulting
wmb-software-consulting
approved these changes
Nov 22, 2023
jianoaix
approved these changes
Nov 28, 2023
ian-shim
force-pushed
the
encoding-queue-limit-test
branch
from
ea90857
to
dea57db
Compare
teddyknox
pushed a commit
that referenced
this pull request
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Instead of trying to get mock encoder to wait to consume workerpool, mock the workerpool itself so we can directly compare the queue size with pool size.
This should address the flakiness as well.
Checks