Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gpu encoder no blob batching #642

Open
wants to merge 6 commits into
base: gpu-encode
Choose a base branch
from
Open

Gpu encoder no blob batching #642

wants to merge 6 commits into from

Conversation

bxue-l2
Copy link
Contributor

@bxue-l2 bxue-l2 commented Jul 16, 2024

Why are these changes needed?

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@bxue-l2 bxue-l2 requested a review from dmanc July 16, 2024 03:40
dmanc
dmanc reviewed Jul 16, 2024
View reviewed changes
Copy link
Contributor

@dmanc dmanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can probably use build tags in order to only compile the cpu code in the docker / unit tests.

https://www.digitalocean.com/community/tutorials/customizing-go-binaries-with-build-tags

@dmanc dmanc mentioned this pull request Aug 21, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmanc dmanc dmanc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bxue-l2 @dmanc