Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate api/ into its own module to avoid dep hell #61

Closed
wants to merge 1 commit into from

Conversation

teddyknox
Copy link
Contributor

Why are these changes needed?

This is needed to build rollup integrations on top of EigenDA to avoid bringing in dependencies that are not necessary for interacting with the EigenDA API, which will often conflict with rollup stack dependencies.

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@teddyknox
Copy link
Contributor Author

Closing this so I can do a PR from my fork: #62

@teddyknox teddyknox closed this Nov 20, 2023
@teddyknox teddyknox deleted the modularize-api branch November 20, 2023 17:02
teddyknox pushed a commit that referenced this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant