Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the NumBatchDeserializationWorkersFlag passing #597

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

jianoaix
Copy link
Contributor

@jianoaix jianoaix commented Jun 5, 2024

Why are these changes needed?

The value of this flag isn't passed

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@jianoaix jianoaix requested a review from ian-shim June 5, 2024 17:27
@jianoaix jianoaix requested review from dmanc and shrimalmadhur June 5, 2024 17:28
Copy link
Contributor

@ian-shim ian-shim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

@jianoaix jianoaix merged commit b344eb2 into Layr-Labs:master Jun 5, 2024
6 checks passed
jianoaix added a commit to jianoaix/eigenda that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants