Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log request protobuf msg size #578

Merged
merged 2 commits into from
May 25, 2024

Conversation

jianoaix
Copy link
Contributor

@jianoaix jianoaix commented May 23, 2024

Why are these changes needed?

The serialized protobuf message is the actual amount of data to be transmitted. And it could be quite different than the accounting in golang.

Example:
2024-05-23 16:14:12.845 | {"time":"2024-05-23T23:14:12.845549648Z","level":"DEBUG","source":{"function":"github.com/Layr-Labs/eigenda/disperser/batcher/grpc.(*dispatcher).sendChunks","file":"/app/disperser/batcher/grpc/dispatcher.go","line":134},"msg":"sending chunks to operator","component":"Dispatcher","operator":"18.218.243.40:32005;32004","size":2689920,"request message size":10682225}

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@jianoaix jianoaix requested review from pschork and bxue-l2 May 23, 2024 23:24
@jianoaix jianoaix merged commit dbbe9d1 into Layr-Labs:master May 25, 2024
5 checks passed
Copy link
Contributor

@pschork pschork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll include it in the release.

pschork pushed a commit that referenced this pull request May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants