Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dataapi] Fix gql error #514

Merged
merged 4 commits into from
Apr 24, 2024
Merged

[Dataapi] Fix gql error #514

merged 4 commits into from
Apr 24, 2024

Conversation

siddimore
Copy link
Contributor

@siddimore siddimore commented Apr 22, 2024 •
edited
Loading

Why are these changes needed?

  1. OperatorId was being truncated when passed and used for querying subgraph resulting in conversion error. This fixes this and we can get status/mdedata of each operator by querying SubGraph.
Screenshot 2024-04-22 at 2 51 23 PM
  1. Increase server write timeout because query to get deregistered operators does take long time to return
  2. Minor fix in main.go

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@siddimore siddimore marked this pull request as ready for review April 23, 2024 00:16
@siddimore siddimore requested a review from pschork April 23, 2024 18:03
@siddimore siddimore merged commit cbff1ae into Layr-Labs:master Apr 24, 2024
5 checks passed
jianoaix
jianoaix reviewed Apr 25, 2024
View reviewed changes
disperser/dataapi/subgraph/api.go
@@ -196,11 +194,13 @@ func (a *api) QueryDeregisteredOperatorsGreaterThanBlockTimestamp(ctx context.Co
return query.OperatorDeregistereds, nil
}

func (a *api) QueryOperatorInfoByOperatorIdAtBlockNumber(ctx context.Context, operatorId core.OperatorID, blockNumber uint32) (*IndexedOperatorInfo, error) {
func (a *api) QueryOperatorInfoByOperatorIdAtBlockNumber(ctx context.Context, operatorId string, blockNumber uint32) (*IndexedOperatorInfo, error) {
fmt.Printf("==QueryOperatorInfoByOperatorIdAtBlockNumber ==== operatorId: %v\n", operatorId)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianoaix jianoaix jianoaix left review comments

@dmanc dmanc dmanc approved these changes

@shrimalmadhur shrimalmadhur Awaiting requested review from shrimalmadhur

@mooselumph mooselumph Awaiting requested review from mooselumph

@pschork pschork Awaiting requested review from pschork

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siddimore @dmanc @jianoaix