Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GithubAction] Push Operator Node Images #51

Merged
merged 5 commits into from
Nov 20, 2023

Conversation

siddimore
Copy link
Contributor

@siddimore siddimore commented Nov 17, 2023

Why are these changes needed?

Needed to push operator node images to public ghcr.
Invoking Role: Oncall
Steps:

  1. Verify Test Results for PreProd run and obtain commit-sha for that (TBD: one place look up for commit-sha to TestResult)
  2. Provide Commit Sha and Release Tag as input parameters to this action
  3. Run workflow

Alternative Considered:

  1. Writing this github action in eigenda-devops
  2. PreProd environment rel has a github action(cronjob) which will publish eigenda components update and run some test
  3. If this PreProd environment rel succeeds then publish Node specific images from ECR to GHCR

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@siddimore siddimore changed the title [GithubAction]Push Operator Node Images [GithubAction] Push Operator Node Images Nov 17, 2023
Copy link
Contributor

@dmanc dmanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do a test run after merging.

@siddimore siddimore merged commit 3bcabda into master Nov 20, 2023
5 checks passed
teddyknox pushed a commit that referenced this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants