Fix: Send only blobs relevant to operators #301
Conversation
disperser/batcher/grpc/dispatcher.go
Outdated
| QuorumThreshold: uint32(header.QuorumThreshold), | ||
| Ratelimit: header.QuorumRate, | ||
| for _, header := range blob.BlobHeader.QuorumInfos { | ||
| if _, ok := blob.Bundles[header.QuorumID]; ok { |
There was a problem hiding this comment.
Shoudn't this always be ok?
There was a problem hiding this comment.
The way it's implemented today, blob.BlobHeader is the same for all blobs sent to all operators. So, when an operator is only registered in quorum 1 and blob is dispersed to quorums 0 and 1, blob.BlobHeader.QuorumInfos will contain both quorums.
However, blob.Bundles is operator specific, so for operator only in quorum 1, blob.Bundles[0] does not exist.
| @@ -138,7 +138,10 @@ type BatchHeader struct { | |||
| } | |||
|
|
|||
| // EncodedBlob contains the messages to be sent to a group of DA nodes corresponding to a single blob | |||
| type EncodedBlob = map[OperatorID]*BlobMessage | |||
| type EncodedBlob struct { | |||
There was a problem hiding this comment.
makes BlobHeader common across all operators
| bundles[i] = &node.Bundle{ | ||
| Chunks: data[quorum], | ||
| } | ||
| } else { |
There was a problem hiding this comment.
Makes sure len(quorumHeaders) == len(bundles)
Bundles will be empty for quorums the operator is not part of
ian-shim
force-pushed
the
multiquorum-send-only-relevant-blobs
branch
from
c11458e to
782cf91
Compare
ian-shim
force-pushed
the
multiquorum-send-only-relevant-blobs
branch
from
782cf91 to
77f2bb4
Compare
disperser/batcher/grpc/dispatcher.go
Outdated
| @@ -153,28 +156,35 @@ func getBlobMessage(blob *core.BlobMessage) (*node.Blob, error) { | |||
| lengthProofData.YA1 = blob.BlobHeader.LengthProof.Y.A1.Marshal() | |||
| } | |||
|
|
|||
| quorumHeaders := make([]*node.BlobQuorumInfo, len(blob.BlobHeader.QuorumInfos)) | |||
| quorumHeaders := make([]*node.BlobQuorumInfo, 0) | |||
There was a problem hiding this comment.
Would it better just to revert the changes here through L168?
|
looks good! |
Why are these changes needed?
For a given encoded blob, it keeps track of blob messages for given operator. If an operator is not part of a quorum and if a blob is dispersed to a quorum the operator is not part of, the encoded blob should not include the operator's blob message, but the blob header should be the same and sent to the operators even if the operator is not part of the quorum the blob is getting dispersed.
This PR makes
BlobHeaderfield inEncodedBlobcommon while having assigning different bundles for different operators. Also, it sends the blob headers to all operators (makes all operators store the blob headers). This is to allow operators to properly validate the batch root for all blob headers. If an operator isn't part of the quorum the blob is dispersed to, it will receive an empty bundle.Checks